-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce cider-ignored-error-phases
#3423
Conversation
@yuhan0 : feel free to review this one, I reckon it might interest you |
cider-eval.el
Outdated
@@ -478,32 +485,63 @@ op/situation that originated this error." | |||
(let ((error-buffer (cider-new-error-buffer #'cider-stacktrace-mode error-types))) | |||
(cider-stacktrace-render error-buffer (reverse causes) error-types)))) | |||
|
|||
(defun cider--handle-stacktrace-response (response causes) | |||
"Handle stacktrace op RESPONSE, aggregating the result into CAUSES. | |||
(defcustom cider-ignored-error-phases '("read-source" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this name is very confusing, as it doesn't indicate any relationship with the stacktrace display functionality. I also have issue with the term "ignored", as I don't think it reflects what we are really doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just name this cider-clojure-compilation-error-phases
or something like this? I doubt anyone would be changing this one much. As noted by you:
A commonly desirable thing would be that one is presented detailed error reports on application-level exceptions. Compile-time exceptions would not deserve them, by default.
cider-eval.el
Outdated
) | ||
"Clojure error phases which will not trigger a UI to become visible. | ||
|
||
Those UIs include, at the moment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given there's just one UI, I'm guessing you can simplify the wording here. :-)
You also need to update the "dealing with errors" docs. |
a650680
to
2d80720
Compare
Thanks for the review! I've amended the last commit applying all feedback. |
2d80720
to
003ebfa
Compare
Amended again The only change:
|
Thanks! |
Commits:
tooling
filter:cider-ignored-error-phases
cider-show-error-buffer
/cider-auto-jump-to-error
: honor:clojure.error/phase
#3418cider-auto-jump-to-error
: also recognise macroexpansion errorsQA
This PR's main focus is easy to QA:
(setq cider-show-error-buffer 'always)
::::a
in the REPL(let [1])
in the REPL(/ 2 0)
*cider-error*
buffer will show uptooling
filter is on, notably few stack frames will be visibleCheers - V